Update integration tests to reflect changes to Arduino Lint output and rules #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent improvements to Arduino Lint caused the golden logs to become outdated: - Improved formatting of output - Correctly catch folder target symlinks, which were previously missed by Arduino Lint, but then caught by the engine's own code
The table package used to format Arduino Lint output fills out the full column width with trailing whitespace. The generated and golden master logs contain mutable strings of different length which are replaced before comparing them in the integration tests. The resulting mismatch will cause a spurious integration test failure. The solution is to strip the trailing whitespace before doing the comparison.
A copy/paste error resulted in a potentially confusing comment.
silvanocerza
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent improvements to Arduino Lint caused the golden logs to become outdated:
The table package used to format Arduino Lint output fills out the full column width with trailing whitespace.
The generated and golden master logs contain mutable strings of different length which are replaced before comparing them
in the integration tests. The resulting mismatch will cause a spurious integration test failure.
The solution is to strip the trailing whitespace before doing the comparison.